Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflects input changes to CBR #311

Conversation

Vismayak
Copy link
Member

@Vismayak Vismayak commented Dec 7, 2023

No description provided.

@longshuicy
Copy link
Member

You might also want to update the workshop session 3 and 4 notebook to accept this new input in the PR? If it's not too much to do

@Vismayak
Copy link
Member Author

Vismayak commented Dec 8, 2023

@longshuicy I already did update the workshop notebooks, thats the one where I pushed to main by mistake

@longshuicy
Copy link
Member

@longshuicy I already did update the workshop notebooks, thats the one where I pushed to main by mistake

That workshop notebook repos are private. Ya-Lan and Chris copied over the material to incore-docs so we can share it as a part of the documentation. Hence you might want to update it here.

They should be under the path of /manual_jb/content/workshops/20231115.

  • You need to modify session 3 & session 4. Session 4 you can just add
commercial_recovery.set_input_dataset("building_dmg", bldg_dmg_result)
  • Session 3 I haven't tried.
  • Lastly, when notebooks updated, you would need to creating a zip file of them, and place it under /workshops/20231115 to replace the outdated one. This is the place where we allow user to download the zipfile.

@ylyangtw
Copy link
Contributor

Tested session3 in zip file, it works. session 4 changes also look good.

Could you remove the __MACOSX in the zip file?
image
If you simply use macos default to zip it, __MACOSX will be generated automatically. You will want to use command line in the terminal instead.

@Vismayak
Copy link
Member Author

@ylyangtw thats weird, I cant see it
image

If you still see it, could you please remove and commit it?

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean now

@longshuicy longshuicy merged commit c8fe100 into develop Dec 11, 2023
1 check passed
@navarroc navarroc deleted the 310-add-additional-damage-as-input-to-commercial-building-recovery-markdown branch December 20, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional damage as input to Commercial Building Recovery markdown
4 participants