Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buyout Model Implementation #553

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

Vismayak
Copy link
Member

@Vismayak Vismayak commented May 2, 2024

No description provided.

@Vismayak Vismayak self-assigned this May 2, 2024
@Vismayak Vismayak linked an issue May 2, 2024 that may be closed by this pull request
@Vismayak Vismayak force-pushed the 539-implementing-the-buyout-model branch from 0a3fcc0 to 49a886f Compare May 2, 2024 15:24
@Vismayak Vismayak changed the title Buyout Model Implementation [WIP] Buyout Model Implementation May 6, 2024
@Vismayak Vismayak force-pushed the 539-implementing-the-buyout-model branch from 0560fa0 to 471dcd9 Compare June 3, 2024 15:02
@navarroc navarroc self-requested a review June 4, 2024 19:59
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and runs well. Approved.

@navarroc
Copy link
Member

navarroc commented Jun 4, 2024

Can you update the modules.rst file in docs/source/modules.rst? Without this, the module documentation won't show up. The rest looks good.

@longshuicy longshuicy merged commit 16932f8 into develop Jun 5, 2024
7 checks passed
@longshuicy longshuicy deleted the 539-implementing-the-buyout-model branch June 5, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing the Buyout Decision Framework as an analyses
3 participants