560 renaming housing recovery to housing valuation recovery

[longshuicy]

1. Use the sphinx deprecation decorator
2. Found an elegant way for he old class to call the new one
3. Update the sphinx doc, also add the deprecation decorator

---

To test:

1. run the old test_housingrecovery.py. This should print out warnings but still execute as it used to.
2. run the new test_housingvaluationrecovery.py.

[navarroc]

I think we'll need to add deprecated to the list of dependencies, right?

[longshuicy]

I think we'll need to add deprecated to the list of dependencies, right?

Hmm sorry I don't follow. Could you give me an example?

[navarroc]

I think we'll need to add deprecated to the list of dependencies, right?

Hmm sorry I don't follow. Could you give me an example?

I had to install the "deprecated" library into my pip environment to run the test so we might need to add it to setup.py. Looking at the conda environment for 1.18.1, it is already there (probably part of the base conda package) or another dependency we have already pulls it in.

[navarroc]

Basic tests pass (checked old output vs new output), the old analysis shows a deprecation message. I also checked/built the module documentation, looks good.

[longshuicy]

I think we'll need to add deprecated to the list of dependencies, right?

Hmm sorry I don't follow. Could you give me an example?

I had to install the "deprecated" library into my pip environment to run the test so we might need to add it to setup.py. Looking at the conda environment for 1.18.1, it is already there (probably part of the base conda package) or another dependency we have already pulls it in.

Ah i see! You are talking about the deprecated library. Yes I think I need to add it good catch!

[longshuicy]

I had to install the "deprecated" library into my pip environment to run the test so we might need to add it to setup.py. Looking at the conda environment for 1.18.1, it is already there (probably part of the base conda package) or another dependency we have already pulls it in.

I added the dependencies:

• Not sure how conda got the "deprecated" library. We are not explicitly listing it in the environment.yml... just to be safe I added there
• For pip, the package name seems to be capitalized "Deprecated"? https://pypi.org/project/Deprecated/