-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
562 update building nonstructural damage to support flood #571
562 update building nonstructural damage to support flood #571
Conversation
pyincore/analyses/nonstructbuildingdamage/nonstructbuildingdamage.py
Outdated
Show resolved
Hide resolved
If I set use_liquefaction and a liquefaction_dataset_id with the flood test, I get an error. I think we have to check to make sure the hazard type is EQ or ignore the liquefaction as we do in building damage. |
…e surge building damage (#577) * update to flood to non structural * update tests * changelog * overwrite the default fragility key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Compared the combined damage before and after the change, results match. Also verified setting liquefaction with the flood hazard works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this error when I ran test_buildingdamage_legacy
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://incore-dev.ncsa.illinois.edu/data/api/datasets/6091d5a8daa06e14ee96d502
Could you check? test_buildingdamage ran okay
All other tests were fine except test_buildingdamage_legacy |
It looks like the retrofit strategy referred to in the test got deleted, I saw the same for road damage, the galveston road inventory referenced is gone. We need some way to mark/protect these test files. This has happened too many times. |
Non structural damage needs to support retrofit_strategy (like building damage). I left a comment on the docs PR, but we should either include that in this PR or open a bug to fix it in a separate PR. |
pyincore/analyses/nonstructbuildingdamage/nonstructbuildingdamage.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using test classes and IN-CORE/incore-docs#394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests were passed. Approve
This PR:
Related PR:
incore-docs: IN-CORE/incore-docs#386