Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Social Vulnerability to Social Vulnerability Score #572

Merged
merged 11 commits into from
May 22, 2024
Merged

Rename Social Vulnerability to Social Vulnerability Score #572

merged 11 commits into from
May 22, 2024

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented May 13, 2024 •
edited
Loading

  • Need to add how to deprecate
  • Add deprecate to requirements
  • Add deprecate to setup
  • Need to update documentation
  • Need to figure out if we change the input data type
  • e.g, social_vulnerability_demographic_factors or socialVulnerabilityFeatureAverages. If so, the dataset type should also be changed

@ywkim312 ywkim312 linked an issue May 13, 2024 that may be closed by this pull request
Rename social vulnerability analysis to social vulnerability score #556
Closed
@ywkim312 ywkim312 self-assigned this May 13, 2024
@ywkim312 ywkim312 marked this pull request as draft May 13, 2024 19:34
@ywkim312 ywkim312 changed the title (WIP) Rename Social Vulnerability to Social Vulnerability Score Rename Social Vulnerability to Social Vulnerability Score May 15, 2024
@ywkim312 ywkim312 marked this pull request as ready for review May 15, 2024 21:14
@ywkim312 ywkim312 mentioned this pull request May 20, 2024
Merged
longshuicy
longshuicy approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the missing copyright year everything looks good.
Both old and new analysis runs and results are identical.
Approving but please add the missing copyright back. Thanks!

pyincore/analyses/socialvulnerability/socialvulnerability.py Outdated Show resolved Hide resolved
navarroc
navarroc reviewed May 22, 2024
View reviewed changes
pyincore/analyses/socialvulnerabilityscore/__init__.py Outdated
@@ -0,0 +1,8 @@
# Copyright (c) 2024 University of Illinois and others. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should match the original copyright year, 2021

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already updated. Maybe you're using the old one? Can you pull one more time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad, changed it.

@ywkim312 ywkim312 merged commit 9e27a3f into develop May 22, 2024
7 checks passed
@ywkim312 ywkim312 deleted the 556-rename-social-vulnerability-analysis-to-social-vulnerability-score branch May 22, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy approved these changes

@navarroc navarroc navarroc approved these changes

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

@ylyangtw ylyangtw Awaiting requested review from ylyangtw

Assignees

@ywkim312 ywkim312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename social vulnerability analysis to social vulnerability score
3 participants
@ywkim312 @navarroc @longshuicy