Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSSOM-Java. #1089

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update SSSOM-Java. #1089

merged 2 commits into from
Aug 12, 2024

Conversation

gouttegd
Copy link
Contributor

@gouttegd gouttegd commented Aug 9, 2024

This PR simply bumps the SSSOM-Java (ROBOT plugin and command line tool) to the latest 0.9.0 version.

Bump the SSSOM-Java (ROBOT plugin and command line tool) to the latest
0.9.0 version.
@gouttegd gouttegd self-assigned this Aug 9, 2024
@gouttegd
Copy link
Contributor Author

gouttegd commented Aug 9, 2024

The CI check failure has nothing to do with SSSOM and is instead caused by this incomprehensible bug when trying to install the Python packages:

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

The conflict is caused by:
    ipykernel 6.29.5 depends on debugpy>=1.6.5
    The user requested (constraint) debugpy==1.8.3

where Python seems to consider that debugpy==1.8.3 (which we forcibly require) does not satisfy ipykernel’s dependency on debugpy>=1.6.5. Because Python.

In local testing, this is “fixed” by bumping to debugpy==1.8.5, so I would expect the bug to automatically go away with the next “constraints update” on Monday.

(What’s even less comprehensible is that the problem did not manifest itself upon the last update of Python constraints #1088, despite the fact that we were already requesting ipykernel==6.29.5 and debugpy==1.8.3 then.)

@gouttegd
Copy link
Contributor Author

So the issue above is caused by debugpy-1.8.3 having been simply deleted from PyPI. Kudos to PIP for not being able to detect that case and hallucinating a bogus error message about “conflicting dependencies” instead.

In that case it should indeed automatically be fixed at the next “constraints update” GH action, which should automatically pick up the new 1.8.5 version. No need to fix it now.

@gouttegd gouttegd requested a review from matentzn August 12, 2024 06:56
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gouttegd gouttegd merged commit fe711c1 into master Aug 12, 2024
1 check passed
@gouttegd gouttegd deleted the update-sssom-java branch August 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants