Remove default user #1090
Remove default user #1090
Conversation
The Ubuntu 24.04 Docker image contains a default user account named `ubuntu` with a UID of 1000. This is a change from the 22.04 image, which did not contain such an account. The presence of that account could cause some confusion as the ODK also creates a `odkuser` user account with a default UID of 1000. To be on the safe side, we explicitly remove the default `ubuntu` account.
This commit refactors some of the last steps of constructing the ODKLite image to reduce the number of FS layers in the final image. Specifically, two "condensations" are performed. 1. `COPY` and `RUN chmod` operations are lumped together: COPY src dst RUN chmod 755 dst now becomes COPY --chmod=755 src dst 2. Several RUN operations are replaced by a single RUN with &&-separated commands: RUN command1 RUN command2 now becomes RUN command1 && command2 This reduces the number of layers in the ODKLite image from 21 to 15.
|
CI check explicitly cancelled since it is bound to fail until the |
FYI as admin of ODK you should feel free to simply run the action and merge the PR after an eyeball review (which only does one thing: checking that no tool decreased in version number, of if it does, it can be explained and dismissed). |
Sure, but in this case, with the next automatic run scheduled to happen tomorrow, there was no real need to trigger an out-of-cycle run. |
One of the removed `RUN chmod` operations in a previous commit had not been replaced by the proper `COPY --chmod`, resulting in the /tools/check-rdfxml script being left with the execution bit unset. We fix that here.
There was a problem hiding this comment.
I tested it with one ontology and I cant see any difference, so I am assuming its all good.
I trust you have, as usual, weighed the risks if there are any; I can only do a LGTM review here as I dont understand the consequences of deleting the default user. :)
|
Deleting the default user should have no consequences at all. On the other hand, leaving the default user in place (that is, without this PR) could lead to confusion and possibly bugs (though I have not so far observed any), because we end up with two entries in For standard workflows, this should not cause any issues because the standard workflows never refer to the user’s home directory anyway. But if you have a custom workflow that somehow needs to refer to the home directory (for example, if you are use Again, I have not observed any such trouble yet, but the mere fact that the possibility exists is reason enough to remove the (useless) default user. |
The Ubuntu 24.04 base image that we now use contains a predefined
ubuntuuser account with a UID of 1000. This could cause some confusion with the ODK’s own user account (odkuser), which by default also has a UID of 1000.There is no need for that
ubuntuaccount, so this PR simply removes it.While we are at it, this PR also refactors the last section of the ODKLite
Dockerfile(where we add the instruction to remove theubuntuuser account) to group several operations together and reduce slightly the number of layers in the ODKLite image.