Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the SSH socket belongs to odkuser. #1096

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

gouttegd
Copy link
Contributor

When we run under a non-privileged user account (which is the default situation), we need to make the SSH authentication socket, if it exists, belongs to the odkuser account. Under some conditions, Docker may create that socket as belonging to root by default.

When we run under a non-privileged user account (which is the default
situation), we need to make the SSH authentication socket, if it exists,
belongs to the odkuser. Under some conditions, Docker may create that
socket as belonging to root by default.
@gouttegd gouttegd self-assigned this Aug 23, 2024
@gouttegd gouttegd requested a review from matentzn August 23, 2024 16:04
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the motivation, but cannot judge the solution. Howeber I have known you long enough to trust that it works as you intend.

@gouttegd gouttegd merged commit d51efea into master Aug 23, 2024
1 check passed
@gouttegd gouttegd deleted the fix-ssh-socket-ownership branch August 23, 2024 18:31
gouttegd added a commit that referenced this pull request Oct 28, 2024
When we run under a non-privileged user account (which is the default
situation), we need to make the SSH authentication socket, if it exists,
belongs to the odkuser. Under some conditions, Docker may create that
socket as belonging to root by default.
@gouttegd gouttegd mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants