Skip to content

Commit

Permalink
Merge pull request #11115 from IQSS/10384-link
Browse files Browse the repository at this point in the history
in "requested access" email, add space after link to prevent it from breaking
  • Loading branch information
ofahimIQSS authored Jan 3, 2025
2 parents f69e688 + 5abbc8d commit 44fd440
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions doc/release-notes/10384-link.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Broken Link in Email When Users Request Access to Files

When users request access to a files, the people who have permission to grant access receive an email with a link in it that didn't work due to a trailing period (full stop) right next to the link (e.g. `https://demo.dataverse.org/permissions-manage-files.xhtml?id=9.`) A space has been added to fix this. See #10384 and #11115.
2 changes: 1 addition & 1 deletion src/main/java/propertyFiles/Bundle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ notification.email.greeting.html=Hello, <br>
# Bundle file editors, please note that "notification.email.welcome" is used in a unit test
notification.email.welcome=Welcome to {0}! Get started by adding or finding data. Have questions? Check out the User Guide at {1}/{2}/user or contact {3} at {4} for assistance.
notification.email.welcomeConfirmEmailAddOn=\n\nPlease verify your email address at {0} . Note, the verify link will expire after {1}. Send another verification email by visiting your account page.
notification.email.requestFileAccess=File access requested for dataset: {0} by {1} ({2}). Manage permissions at {3}.
notification.email.requestFileAccess=File access requested for dataset: {0} by {1} ({2}). Manage permissions at {3} .
notification.email.requestFileAccess.guestbookResponse=<br><br>Guestbook Response:<br><br>{0}
notification.email.grantFileAccess=Access granted for files in dataset: {0} (view at {1} ).
notification.email.rejectFileAccess=Your request for access was rejected for the requested files in the dataset: {0} (view at {1} ). If you have any questions about why your request was rejected, you may reach the dataset owner using the "Contact" link on the upper right corner of the dataset page.
Expand Down

0 comments on commit 44fd440

Please sign in to comment.