Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamHandler shouldn't inherit from asynchat.async_chat #306

Open
mattclarke opened this issue Nov 29, 2021 · 0 comments
Open

StreamHandler shouldn't inherit from asynchat.async_chat #306

mattclarke opened this issue Nov 29, 2021 · 0 comments

Comments

@mattclarke
Copy link
Member

Makes testing a pain as need to be patched out.
Better to wrap an instance of async_chat and call methods on that.
An instance can probably be passed in through the constructor of StreamHandler and this means we can use a test double rather than using "patch".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant