Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests into groups + SafeTestsets #30
Split tests into groups + SafeTestsets #30
Changes from 8 commits
0aef614
77757dc
dc5cf3e
4372ca3
64360a9
b148014
76ea53e
79255d6
6cd80e4
6a9504d
0a6af80
5c3ab3f
f13bc27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
@testset
report times now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. could we achieve this by wrapping all of this in
@testset
or@safetestset
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure, I mostly copied this from my other workflows. I think the main difference is that
@time
also reports splits in compiletime/runtime, which I find interesting, but I have absolutely no preference about this.Just as an aside, wrapping things in nested
@testset
structures makes it such that output is only printed after all tests finish. Not a big deal, but something to keep in mind.This file was deleted.
This file was deleted.
This file was deleted.