Chapter 2: First argument to a function call should be placed in %rdi #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo in the example shown in the assign homes pass. The generated assembly should put the argument for print_int into %rdi instead of %rax, before the callq instruction. The assembly shown for the Python version in the patch instructions pass looks correct, but the racket version still had the typo.
jsiek
reviewed
Sep 28, 2024
|
I've pushed a fix to this problem. Thanks again! |
|
Ah, I see. I didn't realize that. In that case probably the PR can be
closed because you are aware of the problem.
…On Sat, 28 Sept 2024, 23:58 Jeremy G. Siek, ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for noticing this problem!
The solution is a bit more complicated because the assembly code is
correct for the Racket version of the book but not for the Python version.
I'll need to split this out into different code for the different versions.
—
Reply to this email directly, view it on GitHub
<#180 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQE3AZSD6X2RQ5WYEPVE3ZY3YMBAVCNFSM6AAAAABPAOAAM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZVGM4DSNZUGM>
.
You are receiving this because you authored the thread.Message ID:
<IUCompilerCourse/Essentials-of-Compilation/pull/180/review/2335389743@
github.com>
|
|
Thank you!
…On Sun, 29 Sept 2024, 00:15 Jeremy G. Siek, ***@***.***> wrote:
I've pushed a fix to this problem. Thanks again!
—
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQE3F6EUKPBO26WH3TNC3ZY32NNAVCNFSM6AAAAABPAOAAM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQHA3DEMJTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in the example shown in the assign homes pass. The generated assembly should put the argument for print_int into %rdi instead of %rax, before the callq instruction.
The assembly shown for the Python version in the patch instructions pass looks correct, but the racket version still had the typo.