-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitflag Packages #254
Add Bitflag Packages #254
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🥳thanks for putting this together! |
Marking as ready for review for the base package, |
packages/bitflag-js/src/bitfield.ts
Outdated
case "number": | ||
return resolved | BigInt(item); | ||
case "object": | ||
if (item.constructor.name === "BitField") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instance of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh duh 💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the code for discord one. Also redundant since @sapphire/bitfield exists but i digress
I took a look at that package, but the API is wildly different from the one I want to expose - I'm less interested in being a general toolchain and more interested in being specifically targeted at something |
Adds a generic Bitflag package and a discord specific one that builds off of it. cc @RhysSullivan who requested this feature!