You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we recommend installing sopstool via the install.sh script. This installs sops first before installing sopstool. I believe we should instead ask the user to install sops themselves. Other popular wrapper tools like terragrunt or saml2aws do this to simplify management of their tool. I propose we:
Remove the install scripts (install.sh, sopsinstall.sh, sopstoolinstall.sh).
Adjust Travis by downloading (via curl?) a copy of sops 3.7.2 or later directly from the release during the build process.
Adjust the Dockerfile to do the same when we build the image.
Ask the user to install sops as a dependency.
While the scripts themselves aren't a ton of maintenance, it'll just be less the maintain. I'm stuck between hard coding 3.7.2 into Travis or the Dockerfile, or just saying "install sops" and worrying about compatibility ourselves though.
The text was updated successfully, but these errors were encountered:
turns out the sops download still really benefits from having a script to get the current tag, since that value is also in the artifact filenames. Plus, the format for different platforms is not exactly consistent. In #58 I have edited that file to be a little more targeted and added some features.
As for sopstoolinstall and install.sh, I do kind of agree - and in that PR mentioned above, moved those lower in the README. I'm ok with potentially dropping those though. IMO our releases are pretty straightforward to acquire. The install script is just nice because it does automatically solve a couple things like sha256 validation and platform selection.
Current Behavior
Currently, we recommend installing
sopstool
via the install.sh script. This installs sops first before installing sopstool. I believe we should instead ask the user to installsops
themselves. Other popular wrapper tools like terragrunt or saml2aws do this to simplify management of their tool. I propose we:While the scripts themselves aren't a ton of maintenance, it'll just be less the maintain. I'm stuck between hard coding 3.7.2 into Travis or the Dockerfile, or just saying "install
sops
" and worrying about compatibility ourselves though.The text was updated successfully, but these errors were encountered: