-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inefficient list views which render object names #155
Merged
nilmerg
merged 4 commits into
main
from
fix/inefficient-list-views-which-render-object-names-153
Apr 24, 2024
Merged
Fix inefficient list views which render object names #155
nilmerg
merged 4 commits into
main
from
fix/inefficient-list-views-which-render-object-names-153
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
fix/inefficient-list-views-which-render-object-names-153
branch
2 times, most recently
from
January 12, 2024 11:57
13702e3
to
5fa0852
Compare
nilmerg
force-pushed
the
fix/inefficient-list-views-which-render-object-names-153
branch
from
January 15, 2024 15:10
5fa0852
to
724c36e
Compare
sukhwinder33445
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typing in the Searchbar
throws Not implemented
error.
nilmerg
force-pushed
the
fix/inefficient-list-views-which-render-object-names-153
branch
from
January 17, 2024 15:24
724c36e
to
63a774b
Compare
nilmerg
force-pushed
the
fix/inefficient-list-views-which-render-object-names-153
branch
from
January 17, 2024 15:27
63a774b
to
bf387fc
Compare
nilmerg
requested review from
raviks789
and removed request for
sukhwinder33445
April 18, 2024 09:20
nilmerg
force-pushed
the
fix/inefficient-list-views-which-render-object-names-153
branch
from
April 18, 2024 09:21
bf387fc
to
49c3608
Compare
raviks789
approved these changes
Apr 18, 2024
sukhwinder33445
approved these changes
Apr 24, 2024
nilmerg
deleted the
fix/inefficient-list-views-which-render-object-names-153
branch
April 24, 2024 13:57
nilmerg
added a commit
that referenced
this pull request
May 31, 2024
resolves #132 Blocked by: #155, #166 requires: Icinga/ipl-web#217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153
requires Icinga/ipl-orm#128, Icinga/ipl-orm#126 and Icinga/ipl-orm#124