Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cmd/channel to cmd/channels #224

Closed
oxzi opened this issue Jun 27, 2024 · 0 comments · Fixed by #225
Closed

Rename cmd/channel to cmd/channels #224

oxzi opened this issue Jun 27, 2024 · 0 comments · Fixed by #225
Assignees

Comments

@oxzi
Copy link
Member

oxzi commented Jun 27, 2024

It's still singular "channel" for the time being:

c.ChannelPluginDir = internal.LibExecDir + "/icinga-notifications/channel"

Originally posted by @julianbrost in #210 (comment)

@oxzi oxzi self-assigned this Jun 27, 2024
oxzi added a commit that referenced this issue Jun 27, 2024
There are multiple channel plugins under cmd/channel. Especially later
in the installation, the channels directory will contain multiple
channels, not just one.

Closes #224
oxzi added a commit that referenced this issue Jun 27, 2024
There are multiple channel plugins under cmd/channel. Especially later
in the installation, the channels directory will contain multiple
channels, not just one.

For consistency, the YAML configuration channel-plugin-dir was renamed
to channels-dir. The "plugin" part was dropped as it is redundant here.

Closes #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant