Rename cmd/channel to cmd/channels #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
force-pushed
the
cmd-channel-to-channels-i224
branch
from
96a716e to
114a362
Compare
oxzi
commented
Jun 27, 2024
There are multiple channel plugins under cmd/channel. Especially later in the installation, the channels directory will contain multiple channels, not just one. For consistency, the YAML configuration channel-plugin-dir was renamed to channels-dir. The "plugin" part was dropped as it is redundant here. Closes #224
oxzi
force-pushed
the
cmd-channel-to-channels-i224
branch
from
114a362 to
fbefd75
Compare
julianbrost
approved these changes
Jun 27, 2024
yhabteab
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple channel plugins under cmd/channel. Especially later in the installation, the channels directory will contain multiple channels, not just one.
Closes #224