Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/01-About.md: Remove relative link outside doc #229

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jul 8, 2024

First, relative links outside the doc directory are possible and work. However, the main page can be accessed via …/ or …/doc/01-About.md. While a relative link works for the second, it breaks for the first.

For the docs, this link now points to the LICENSE file on GitHub.

Reported-by: Noé Costa #210 (comment)

First, relative links outside the `doc` directory are possible and work.
However, the main page can be accessed via `…/` or `…/doc/01-About.md`.
While a relative link works for the second, it breaks for the first.

For the docs, this link now points to the LICENSE file on GitHub.

Reported-by: Noé Costa <#210 (comment)>
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 8, 2024
@oxzi oxzi requested review from julianbrost and ncosta-ic July 8, 2024 06:52
@oxzi oxzi added the doc Documentation related label Jul 8, 2024
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the main page can be accessed via …/ or …/doc/01-About.md. While a relative link works for the second, it breaks for the first.

Currently, both are broken though:

@julianbrost julianbrost merged commit f369a11 into main Jul 10, 2024
12 checks passed
@julianbrost julianbrost deleted the docs-01-About-GPL-URL branch July 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR doc Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants