Storage: Define type of generic class ConfigObject

Icinga · Apr 19, 2024 · ca62081 · ca62081
1 parent 77d5af4
commit ca62081
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/library/Businessprocess/Storage/Storage.php b/library/Businessprocess/Storage/Storage.php
@@ -15,13 +15,13 @@ abstract class Storage
     protected static $instance;
 
     /**
-     * @var ConfigObject
+     * @var ConfigObject<string>
      */
     protected $config;
 
     /**
      * Storage constructor.
-     * @param ConfigObject $config
+     * @param ConfigObject<string> $config
      */
     public function __construct(ConfigObject $config)
     {

diff --git a/phpstan-baseline-standard.neon b/phpstan-baseline-standard.neon
@@ -3570,11 +3570,6 @@ parameters:
 			count: 1
 			path: library/Businessprocess/Storage/LegacyStorage.php
 
-		-
-			message: "#^Method Icinga\\\\Module\\\\Businessprocess\\\\Storage\\\\Storage\\:\\:__construct\\(\\) has parameter \\$config with generic class Icinga\\\\Data\\\\ConfigObject but does not specify its types\\: TValue$#"
-			count: 1
-			path: library/Businessprocess/Storage/Storage.php
-
 		-
 			message: "#^Method Icinga\\\\Module\\\\Businessprocess\\\\Storage\\\\Storage\\:\\:deleteProcess\\(\\) has parameter \\$name with no type specified\\.$#"
 			count: 1
@@ -3615,11 +3610,6 @@ parameters:
 			count: 1
 			path: library/Businessprocess/Storage/Storage.php
 
-		-
-			message: "#^Property Icinga\\\\Module\\\\Businessprocess\\\\Storage\\\\Storage\\:\\:\\$config with generic class Icinga\\\\Data\\\\ConfigObject does not specify its types\\: TValue$#"
-			count: 1
-			path: library/Businessprocess/Storage/Storage.php
-
 		-
 			message: "#^Method Icinga\\\\Module\\\\Businessprocess\\\\Web\\\\Component\\\\BpDashboardTile\\:\\:__construct\\(\\) has parameter \\$attributes with no type specified\\.$#"
 			count: 1