fix/indistinguishable-suggestions-introduce-lable-427

Icinga · Jan 26, 2024 · e7df347 · e7df347
1 parent b5e8d1d
commit e7df347
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/application/controllers/SuggestionsController.php b/application/controllers/SuggestionsController.php
@@ -101,8 +101,7 @@ public function processAction()
                     ) {
                         yield [
                             'search' => $search,
-                            'label'  => ($bpNode->getAlias() ?? $bpNode->getName())
-                                . " (" . implode("->", $bpNode->getPaths()[0]) . ")",
+                            'label'  => $bpNode->getLabel(),
                             'config' => $config
                         ];
                     }

diff --git a/application/forms/AddNodeForm.php b/application/forms/AddNodeForm.php
@@ -236,7 +236,7 @@ protected function assembleExistingProcessElements(): void
                                 if (! $bp->hasNode($nodeName)) {
                                     $term->setMessage($this->translate('No node with this name found in config'));
                                 } else {
-                                    $term->setLabel($bp->getNode($nodeName)->getAlias());
+                                    $term->setLabel($bp->getNode($nodeName)->getLabel());
                                 }
                             }
                         }

diff --git a/library/Businessprocess/BpNode.php b/library/Businessprocess/BpNode.php
@@ -370,6 +370,12 @@ public function getAlias()
         return $this->alias ? preg_replace('~_~', ' ', $this->alias) : $this->name;
     }
 
+    public function getLabel()
+    {
+        return ($this->alias ?? $this->name)
+            . ' (' . implode(' » ', $this->getPaths()[0]) . ')';
+    }
+
     /**
      * @return int
      */