Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indistinguishable suggestions for nodes #433

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Fix indistinguishable suggestions for nodes #433

merged 5 commits into from
Apr 23, 2024

Conversation

moreamazingnick
Copy link
Contributor

refs #427

@cla-bot cla-bot bot added the cla/signed label Jan 10, 2024
@nilmerg nilmerg self-requested a review January 10, 2024 15:56
@nilmerg nilmerg added the bug Something isn't working label Jan 10, 2024
@nilmerg nilmerg added this to the 2.5.1 milestone Jan 10, 2024
nilmerg
nilmerg requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the suggestion list. It's missing in the label after a suggestion is chosen. This can be adjusted in AddNodeForm::assembleExistingProcessElements().

application/controllers/SuggestionsController.php Outdated Show resolved Hide resolved
@nilmerg nilmerg requested a review from sukhwinder33445 April 19, 2024 10:01
sukhwinder33445
sukhwinder33445 requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use getLabel() on line 247 as well.

icingaweb2-module-businessprocess/application/forms/AddNodeForm.php

Line 247 in 3a0b40a

$term->setLabel($this->bp->getNode($nodeName)->getAlias());

otherwise the selected nodes can no longer be differentiated.

@sukhwinder33445
Copy link
Contributor

@moreamazingnick, can you please make the change so that we can merge the PR and prepare for release?

@sukhwinder33445 sukhwinder33445 self-requested a review April 23, 2024 13:36
@nilmerg nilmerg merged commit e9a551e into Icinga:main Apr 23, 2024
13 checks passed
@sukhwinder33445 sukhwinder33445 mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

@nilmerg nilmerg nilmerg approved these changes

Assignees

@moreamazingnick moreamazingnick

Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@moreamazingnick @sukhwinder33445 @nilmerg