Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that handled nodes are not handled #438

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix that handled nodes are not handled #438

merged 1 commit into from
Apr 22, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Feb 21, 2024

No description provided.

@nilmerg nilmerg added the bug Something isn't working label Feb 21, 2024
@nilmerg nilmerg added this to the 2.5.1 milestone Feb 21, 2024
@cla-bot cla-bot bot added the cla/signed label Feb 21, 2024
@nilmerg nilmerg linked an issue Feb 21, 2024 that may be closed by this pull request
Ignore ack, downtime sub-processes in overall node state #428
Closed
@nilmerg nilmerg added the ref/IP label Feb 21, 2024
@nilmerg nilmerg self-assigned this Feb 21, 2024
@nilmerg nilmerg requested a review from sukhwinder33445 April 19, 2024 09:59
@nilmerg nilmerg force-pushed the fix/handled-nodes-are-not-handled branch from e190b1c to fc9e4c1 Compare April 22, 2024 08:35
@sukhwinder33445
Copy link
Contributor

Note: The changes affect the count badge in the navigation and the process check command (that the handled child nodes are not counted as a problem when the "details" flag is used).

sukhwinder33445
sukhwinder33445 requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process check command with the "details" flag used to always output the same result, regardless of whether a node was handled or not. Now the results are different.

@nilmerg nilmerg force-pushed the fix/handled-nodes-are-not-handled branch from fc9e4c1 to ab3ca59 Compare April 22, 2024 11:21
@nilmerg nilmerg force-pushed the fix/handled-nodes-are-not-handled branch from ab3ca59 to 88d8a8d Compare April 22, 2024 11:27
@nilmerg nilmerg requested a review from sukhwinder33445 April 22, 2024 11:27
@nilmerg nilmerg merged commit 3a0b40a into main Apr 22, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/handled-nodes-are-not-handled branch April 22, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

Assignees

@nilmerg nilmerg

Labels
bug Something isn't working cla/signed ref/IP
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Ignore ack, downtime sub-processes in overall node state
2 participants
@nilmerg @sukhwinder33445