Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.less: Fix align of action-bar and sort control #441

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

sukhwinder33445
Copy link
Contributor

fixes #421

@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Mar 26, 2024
@sukhwinder33445 sukhwinder33445 added this to the 2.5.1 milestone Mar 26, 2024
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg March 26, 2024 10:01
@sukhwinder33445 sukhwinder33445 self-assigned this Mar 26, 2024
@cla-bot cla-bot bot added the cla/signed label Mar 26, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the fix/sort-control-align branch from 65f0556 to a8fd0c8 Compare March 26, 2024 14:57
raviks789
raviks789 previously approved these changes Mar 26, 2024
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the exact problem is fixed, the action-bar is still a complete mess, when the column is too narrow. We should fix that, when we're currently working on the module.

Screenshot 2024-03-27 at 15 13 56

Please decide for yourself, if you want to fix it in this PR or create another one.

I'd suggest the following:

  • Use the regular font-size (1em)
  • Prevent labels (plus icons) from line breaks
  • Ellipsisize labels, when too narrow
  • Add title for making ellipsisized label content accessible
  • Use proper spacing between element rows, when the flex-container wraps

See Icinga DB Web's quick action bar for reference.

Screenshot 2024-03-27 at 15 22 14

Screenshot 2024-03-27 at 15 22 07

@sukhwinder33445 sukhwinder33445 force-pushed the fix/sort-control-align branch from a8fd0c8 to 170a51c Compare March 28, 2024 16:09
@sukhwinder33445 sukhwinder33445 changed the title Align sort control to the left module.less: Fix align of action-bar and sort control Mar 28, 2024
@sukhwinder33445
Copy link
Contributor Author

I have fixed it according to your suggestions, except for the following:

  • The regular font size looks too small here, so I left it as it is.
  • Ellipsisize is not required, as the labels are small.

Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so far.

Please remove the font-size attribute in line 13 (see in line comment).

As for the line-breaks. You are right, the flex wrap happens before the line-break. So that's fine.

public/css/module.less Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the fix/sort-control-align branch from 170a51c to e8859ae Compare April 3, 2024 07:42
@sukhwinder33445 sukhwinder33445 requested review from flourish86 and removed request for flourish86 April 11, 2024 11:55
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please apply the right margin of the last item and the overall bottom margin to the container, not the items.
  • the first item should not have a left margin

public/css/module.less Show resolved Hide resolved
Use regular font-size (1em) for action-bar
@sukhwinder33445 sukhwinder33445 force-pushed the fix/sort-control-align branch from 8525516 to 42c724d Compare April 19, 2024 10:25
@nilmerg nilmerg merged commit 77d5af4 into main Apr 19, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/sort-control-align branch April 19, 2024 10:27
@nilmerg nilmerg removed the request for review from flourish86 April 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort control overlaps action bar
4 participants