Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasBasketSupport for TimePeriods #2543

Conversation

EmmaTinten
Copy link

This adds the missing "hasBasketSupport" for TimePeriodController which allows to add the TimePeriod to specific baskets.

Fixes Missing "Add to basket" for TimePeriods #2542

@cla-bot
Copy link

cla-bot bot commented Jun 2, 2022

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @adaevitncar

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@adaevitncar
Copy link
Contributor

Please verify signed CLA.

@bobapple
Copy link
Member

bobapple commented Jun 3, 2022

@cla-bot check

@lippserd
Copy link
Member

@raviks789 please check this PR.

Copy link
Collaborator

@raviks789 raviks789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lippserd lippserd added this to the v1.11.2 milestone Nov 6, 2024
@lippserd lippserd force-pushed the fix/2542-missing-add-to-basket-for-timeperiods branch from 801809f to 1835661 Compare November 7, 2024 12:16
@lippserd lippserd merged commit 5daa3a8 into Icinga:master Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "Add to basket" for TimePeriods
5 participants