Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IcingaMultiEditForm: Fix editing custom vars with space in their name #2900

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

raviks789
Copy link
Collaborator

fix #2899

@raviks789 raviks789 self-assigned this Aug 2, 2024
@cla-bot cla-bot bot added the cla/signed label Aug 2, 2024
@raviks789 raviks789 force-pushed the fix/multi-edit-custom-var-with-space branch 2 times, most recently from 0d13629 to 26ed224 Compare August 2, 2024 10:48
@raviks789 raviks789 added this to the v1.11.2 milestone Aug 13, 2024
@raviks789 raviks789 force-pushed the fix/multi-edit-custom-var-with-space branch from 26ed224 to 5952f34 Compare October 22, 2024 14:45
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should support spaces in names at all, but changes look good.

@lippserd lippserd force-pushed the fix/multi-edit-custom-var-with-space branch from 5952f34 to 5298c8e Compare November 7, 2024 10:21
@lippserd lippserd merged commit d9b3b23 into master Nov 7, 2024
15 checks passed
@lippserd lippserd deleted the fix/multi-edit-custom-var-with-space branch November 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Select and assign of value on data field with space in name creates new custom var
2 participants