Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix english in GUI labels #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angelorosacewp
Copy link

Current Behavior

There is written the word "directoy" in modules/fileshipper/library/Fileshipper/ProvidedHook/Director/ImportSource.php and
' defaults to double quote: "' in the same file, which is not true as the field requires a character

screenshot from 2019-02-07 16-58-21

How to reproduce

  • Director
  • Import data sources
  • Add
  • under "source type" select Fileshipper
  • look at the additional options that pop up

My Environment

  • Director Version: 1.5.1
  • Icinga 2 version: 2.10.1-1
  • Operating System and version: Centos 7
  • PHP versions: rh-php71-php-fpm-7.1.8

Comment

This pull request refers to the pull request (#28) but with suggestions from @Thomas-Gelf

@u238 u238 deleted the bugfix/Fix-GUI-labels branch September 12, 2019 08:45
@Al2Klimov Al2Klimov requested a review from Thomas-Gelf October 8, 2020 10:27
Copy link
Member

@martialblog martialblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martialblog
Copy link
Member

@Thomas-Gelf This PR can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants