meson: Explicitly set run_command() check parameter #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
requested review from
dpino,
clopez,
psaavedra,
csaavedra and
carlosgcampos
TingPing
reviewed
Sep 12, 2024
aperezdc
force-pushed
the
aperezdc/meson-command-warning
branch
from
e780efa to
7a97895
Compare
|
There are some typos in the log message. |
Set the "check" parameter in run_command() calls, instead of relying on
the default value, which might get changed at some point in the future.
This silences the following Meson warning:
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: mesonbuild/meson#9300
aperezdc
force-pushed
the
aperezdc/meson-command-warning
branch
from
7a97895 to
1d4a8b8
Compare
Fixed, thanks! |
TingPing
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the "check" parameter in run_command() calls, instead of relying on the default value, which might get changed at some point in the future.
This silences the following Meson warning: