Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed state persistence sample- checking & unchecking options #856

Open
wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

Fixed state persistence sample- checking & unchecking options #856

wants to merge 1 commit into from

Conversation

MarielaTihova
Copy link
Contributor

Resolves #855

@tishko0
Copy link
Contributor

tishko0 commented Nov 29, 2024

It seems deselecting a feature does not really disable this feature. While the button does deselect all features, I can still sort, select columns, etc.

@tishko0 tishko0 added the status: in-review PR ready for review label Nov 29, 2024
@MarielaTihova
Copy link
Contributor Author

It seems deselecting a feature does not really disable this feature. While the button does deselect all features, I can still sort, select columns, etc.

As discussed, this is by design. Not an issue caused by this PR. If we want different behaviour, this should be a feature request. @dkamburov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov Awaiting requested review from dkamburov

At least 1 approving review is required to merge this pull request.

Assignees

@tishko0 tishko0

Labels
status: in-review PR ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State Persistence Sample: Toggling 'All Features' checkbox does not work as expected
2 participants
@MarielaTihova @tishko0