Fix nk_font_bake_convert() for big-endian machines #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobLoach
reviewed
Dec 29, 2024
| *dst++ = 0xff; // r | ||
| *dst++ = 0xff; // g | ||
| *dst++ = 0xff; // b | ||
| *dst++ = *src++; // a |
There was a problem hiding this comment.
Need to have /* comments for C89.
Also, does this still work on non-big endian devices? The RGB bit order should be fine, but I am unclear.
RobLoach
requested changes
Dec 29, 2024
| @@ -17230,7 +17230,7 @@ nk_font_bake_convert(void *out_memory, int img_width, int img_height, | |||
| const void *in_memory) | |||
| { | |||
| int n = 0; | |||
| nk_rune *dst; | |||
| nk_byte *dst; | |||
There was a problem hiding this comment.
Thanks a lot for the update. Would you mind making this change in the src destroy? We use paq.sh to combine the files, so wouldn't want to lose your changes.
There was a problem hiding this comment.
Thanks, I will do the needed changes today or tomorrow and I'll ping you back.
There was a problem hiding this comment.
I tested the changes on a little endian machine, the conversion still works.
I added the changes to the src directory as well; should I remove them from nuklear.h, or is it OK like it is now?
Fix the byte order for converting alpha images into RGBA by writing the destination byte-by-byte. The compiler should anyway be able to optimize this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the byte order for converting alpha images into RGBA by writing the destination byte-by-byte. The compiler should anyway be able to optimize this.