BUGFIX: fixed report persist. Also added integration test and update …

…readme.md.

.travis.yml

@@ -16,6 +16,8 @@ install:
   - yarn
 script:
   - yarn lint
+  - yarn test
+  - ./bin/integTest.sh
 after_success:
   - yarn release
   - yarn global add @immowelt/docker-publish

README.md

@@ -40,4 +40,4 @@ docker run -v /path/for/reports:/usr/src/app/lighthouse immowelt/lighthouse-ci:l
 * Threshold configuration via config file
 * Create node API
 * ~~Dockerized images for direct usage in CI pipeline~~
-* ***Unit tests are missing!***
+* ~~Unit tests are missing!~~

bin/integTest.sh

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+# break on all failures
+set -e
+
+# Integration Test for report generation
+node ./bin/ci.js https://immowelt.de -r

src/report.js

@@ -1,13 +1,15 @@
+const Promise = require('bluebird')
 const { resolve } = require('path')
-const { existsSync, mkdirSync, writeFileSync } = require('fs')
+const { existsSync, mkdirSync, writeFile } = require('fs')
 
 const persist = (fileName, fileData, fileDestination) => {
   if (!existsSync(fileDestination)) {
     mkdirSync(fileDestination)
   }
   const filePathAndName = resolve(fileDestination, fileName)
-  writeFileSync(filePathAndName, fileData)
-  return filePathAndName
+  return Promise
+    .promisify(writeFile)(filePathAndName, fileData)
+    .thenReturn(filePathAndName)
 }
 
 module.exports = { persist }

src/report.spec.js

@@ -11,12 +11,12 @@ describe('report', () => {
     existsSync.mockImplementation(() => false)
     const persisted = persist('report.html', 'data', '/dest')
     expect(mkdirSync.mock.calls.length).toBe(1)
-    expect(persisted).toBe('/dest/report.html')
+    persisted.then(data => expect(data).toBe('/dest/report.html'))
   })
   it('.persist() should persist and skip folder creation because path destination does exist', () => {
     existsSync.mockImplementation(() => true)
     const persisted = persist('report.html', 'data', '/dest')
     expect(mkdirSync.mock.calls.length).toBe(0)
-    expect(persisted).toBe('/dest/report.html')
+    persisted.then(data => expect(data).toBe('/dest/report.html'))
   })
 })