Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERS logs page #283

Merged
merged 4 commits into from
Dec 20, 2024
Merged

ERS logs page #283

merged 4 commits into from
Dec 20, 2024

Conversation

jamesturner246
Copy link
Contributor

Description

Add a simple view for displaying erskafka-reporting messages. Just uses the modular messages panel with the ERS topic, as in the main controller page.

Also remove the default ALL topic for the message panel. Not needed, and is causing problems.

Fixes #166
Fixes #168

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (6577b17) to head (d98d647).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
controller/views/pages.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   86.03%   85.93%   -0.10%     
==========================================
  Files          38       38              
  Lines         580      583       +3     
==========================================
+ Hits          499      501       +2     
- Misses         81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, but it is not really addressing the issue, which indicates that the logs should be rendered in a table with multiple columns. Even if we don't have enough information to populate the table in full, eg. no severity, it will be good if we create the page as it should be, just using placeholders for now for the missing data.

The expected table is supposed to look like:
image

@jamesturner246
Copy link
Contributor Author

That's what this PR is supposed to be doing! Not sure what you are seeing. Let's chat.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it wrong - didn't run it and, out of the code, I didn't realised it was a table what we were dealing with.

All good!

@jamesturner246 jamesturner246 merged commit bdcebf8 into main Dec 20, 2024
4 checks passed
@jamesturner246 jamesturner246 deleted the ers_logs branch December 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller UI - PoC Controller Log Page - PoC
3 participants