-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERS logs page #283
ERS logs page #283
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 86.03% 85.93% -0.10%
==========================================
Files 38 38
Lines 580 583 +3
==========================================
+ Hits 499 501 +2
- Misses 81 82 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good, but it is not really addressing the issue, which indicates that the logs should be rendered in a table with multiple columns. Even if we don't have enough information to populate the table in full, eg. no severity, it will be good if we create the page as it should be, just using placeholders for now for the missing data.
That's what this PR is supposed to be doing! Not sure what you are seeing. Let's chat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it wrong - didn't run it and, out of the code, I didn't realised it was a table what we were dealing with.
All good!
Description
Add a simple view for displaying
erskafka-reporting
messages. Just uses the modular messages panel with the ERS topic, as in the main controller page.Also remove the default
ALL
topic for the message panel. Not needed, and is causing problems.Fixes #166
Fixes #168
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks