Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic custom contact information #83

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Oct 29, 2024


Enter a brief description of the PR contents here

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

Screencast.from.2024-10-29.13-57-16.webm

@J4bbi J4bbi force-pushed the feature/custom_contact_information_field branch 4 times, most recently from 35fc84a to d070bfa Compare October 29, 2024 15:50
@J4bbi J4bbi force-pushed the feature/custom_contact_information_field branch from d070bfa to 0ed5e4d Compare November 7, 2024 11:34
@J4bbi J4bbi marked this pull request as ready for review November 11, 2024 16:44
@cc-a cc-a self-requested a review November 12, 2024 14:13
Copy link
Collaborator

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @J4bbi. One thing I noticed was that on the edit form if you click away from the input the text colour changes to white. I assume this will be sorted in #68 so will make a note to check.

@cc-a cc-a force-pushed the feature/custom_contact_information_field branch from 4c5b6f2 to d718416 Compare November 20, 2024 11:49
@cc-a cc-a enabled auto-merge November 20, 2024 11:49
@cc-a cc-a merged commit 8dfc5ba into develop Nov 20, 2024
2 checks passed
@cc-a cc-a deleted the feature/custom_contact_information_field branch November 20, 2024 11:56
@amdomanska amdomanska self-requested a review December 3, 2024 09:33
This was referenced Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants