Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make communities required for submissions #96

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Dec 11, 2024

This PR partially addresses our requirements around reviewer workflow by requiring that all records are members of a community. This was added as an InvenioRDM feature to invenio-rdm-records v10.9.0.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@cc-a cc-a requested a review from J4bbi December 11, 2024 12:39
@cc-a cc-a changed the title Make communities required for subissansio Make communities required for submissions Dec 11, 2024
@J4bbi
Copy link
Collaborator

J4bbi commented Dec 11, 2024

@cc-a this will break importing the test data, how do you want to resolve that?

@Steven-Eardley
Copy link
Collaborator

I suggest we ignore it breaking the data import script, and modify that as required once we have a community to target.

@cc-a cc-a force-pushed the require-community branch from 033b163 to 722b3d1 Compare December 17, 2024 16:29
@cc-a cc-a enabled auto-merge December 17, 2024 16:29
@cc-a cc-a merged commit 146d6ce into develop Dec 17, 2024
2 checks passed
@cc-a cc-a deleted the require-community branch December 17, 2024 16:35
@cc-a cc-a mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants