fix: Dynamic require of "fs" is not supported. fixes #13 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves dotenv and dotenv-expand into `dependencies` from `devDependencies`, which lets tsup externalize them. Therefore, in the bundled code, they will be imported using native `import`s instead of `__require`s generated by esbuild, which in turn tries to call native `require` on NodeJS, which is not supported in NodeJS when the file is treated as an ESM. The detailed cause is clear in evanw/esbuild#1921.
|
Thanks a lot. v2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves dotenv and dotenv-expand into
dependenciesfromdevDependencies, which lets tsup externalize them. Therefore, in the bundled code, they will be imported using nativeimports instead of__requires generated by esbuild, which in turn tries to call nativerequireon NodeJS, which is not supported in NodeJS when the file is treated as an ESM. The detailed cause is clear in evanw/esbuild#1921.