Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network dependency in tests #2

Open
karleitner opened this issue Jun 20, 2023 · 0 comments
Open

Network dependency in tests #2

karleitner opened this issue Jun 20, 2023 · 0 comments

Comments

@karleitner
Copy link
Contributor

Remove the external analytics API dependency which can cause previously passed tests to fail for the same commit hash.

  • Analytics API requests need to be mocked.
  • Tests should pass offline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant