From 88ad3255a6ef2367ec293243e6554978f2ad6e72 Mon Sep 17 00:00:00 2001
From: James Barr <barr.james.r@gmail.com>
Date: Fri, 10 Mar 2017 14:52:20 -0800
Subject: [PATCH 1/2] Add TravisCI config file

---
 .travis.yml                                    | 15 +++++++++++++++
 ViewPumpSample/build.gradle                    | 18 ++++++++++--------
 ViewPumpSample/src/main/AndroidManifest.xml    |  2 +-
 .../viewpump/sample/CustomTextView.java        |  2 ++
 .../sample/TextUpdatingInterceptor.java        |  2 +-
 .../src/main/res/layout/activity_main.xml      |  3 +--
 ViewPumpSample/src/main/res/values/dimens.xml  |  4 ----
 ViewPumpSample/src/main/res/values/strings.xml |  3 ++-
 gradle/wrapper/gradle-wrapper.properties       |  2 +-
 viewpump/build.gradle                          |  9 ++++++++-
 10 files changed, 41 insertions(+), 19 deletions(-)
 create mode 100644 .travis.yml
 delete mode 100644 ViewPumpSample/src/main/res/values/dimens.xml

diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 0000000..a34b25f
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,15 @@
+language: android
+
+jdk: oraclejdk8
+
+android:
+  components:
+    - tools
+    - android-25
+    - build-tools-25.0.2
+    - platform-tools
+    - extra-android-m2repository
+
+cache:
+  directories:
+    - $HOME/.gradle
diff --git a/ViewPumpSample/build.gradle b/ViewPumpSample/build.gradle
index e6b86bc..2d9ba28 100644
--- a/ViewPumpSample/build.gradle
+++ b/ViewPumpSample/build.gradle
@@ -2,11 +2,11 @@ apply plugin: 'com.android.application'
 
 android {
     compileSdkVersion 25
-    buildToolsVersion "25.0.1"
+    buildToolsVersion "25.0.2"
 
     defaultConfig {
         minSdkVersion 14
-        targetSdkVersion 24
+        targetSdkVersion 25
         versionCode project.ext.versionCodeInt
         versionName version
     }
@@ -23,18 +23,20 @@ android {
     }
 
     lintOptions {
-        disable 'AppCompatCustomView'
+        // we don't need to be indexed by firebase and we don't have a custom icon for our sample app
+        disable 'GoogleAppIndexingWarning', 'MissingApplicationIcon'
+        textOutput 'stdout'
+        textReport System.getenv('CI') == 'true'
     }
 }
 
 dependencies {
     compile project(':viewpump')
-    compile 'com.android.support:support-v4:25.0.1'
-    compile 'com.android.support:appcompat-v7:25.0.1'
+    compile 'com.android.support:support-v4:25.2.0'
+    compile 'com.android.support:appcompat-v7:25.2.0'
 
     compile 'com.jakewharton:butterknife:8.2.1'
 
-//    debugCompile 'com.squareup.leakcanary:leakcanary-android:1.3.1'
-    debugCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.3.1'
-    releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.3.1'
+    debugCompile 'com.squareup.leakcanary:leakcanary-android:1.5'
+    releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.5'
 }
diff --git a/ViewPumpSample/src/main/AndroidManifest.xml b/ViewPumpSample/src/main/AndroidManifest.xml
index 356ce43..8989b2e 100644
--- a/ViewPumpSample/src/main/AndroidManifest.xml
+++ b/ViewPumpSample/src/main/AndroidManifest.xml
@@ -5,7 +5,7 @@
 
     <application
         android:name="io.github.inflationx.viewpump.sample.ViewPumpApplication"
-        android:allowBackup="true"
+        android:allowBackup="false"
         android:label="@string/app_name"
         android:theme="@style/AppTheme">
         <activity
diff --git a/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/CustomTextView.java b/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/CustomTextView.java
index 0673f01..083a247 100644
--- a/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/CustomTextView.java
+++ b/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/CustomTextView.java
@@ -1,9 +1,11 @@
 package io.github.inflationx.viewpump.sample;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.util.AttributeSet;
 import android.widget.TextView;
 
+@SuppressLint("AppCompatCustomView")
 public class CustomTextView extends TextView {
 
     public CustomTextView(Context context) {
diff --git a/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/TextUpdatingInterceptor.java b/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/TextUpdatingInterceptor.java
index caa7345..41536c3 100644
--- a/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/TextUpdatingInterceptor.java
+++ b/ViewPumpSample/src/main/java/io/github/inflationx/viewpump/sample/TextUpdatingInterceptor.java
@@ -25,7 +25,7 @@ public InflateResult intercept(Chain chain) {
                     if (text.toString().startsWith("\n")) {
                         text = text.toString().substring(1);
                     }
-                    textView.setText("\n[CustomTextView] " + text);
+                    textView.setText(textView.getContext().getString(R.string.custom_textview_prefixed_text, text));
                 }
             } finally {
                 if (a != null) {
diff --git a/ViewPumpSample/src/main/res/layout/activity_main.xml b/ViewPumpSample/src/main/res/layout/activity_main.xml
index 9de9237..2669a82 100644
--- a/ViewPumpSample/src/main/res/layout/activity_main.xml
+++ b/ViewPumpSample/src/main/res/layout/activity_main.xml
@@ -10,9 +10,8 @@
         android:id="@+id/toolbar"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:background="@color/primary_material_light"
+        android:background="#f5f5f5"
         android:minHeight="?attr/actionBarSize"
-        android:translationZ="4dp"
         android:theme="@style/ThemeOverlay.AppCompat.Light"/>
 
     <LinearLayout
diff --git a/ViewPumpSample/src/main/res/values/dimens.xml b/ViewPumpSample/src/main/res/values/dimens.xml
deleted file mode 100644
index fe991af..0000000
--- a/ViewPumpSample/src/main/res/values/dimens.xml
+++ /dev/null
@@ -1,4 +0,0 @@
-<resources>
-    <dimen name="activity_horizontal_margin">16dp</dimen>
-    <dimen name="activity_vertical_margin">16dp</dimen>
-</resources>
diff --git a/ViewPumpSample/src/main/res/values/strings.xml b/ViewPumpSample/src/main/res/values/strings.xml
index 3fddc3d..9bcd1fd 100644
--- a/ViewPumpSample/src/main/res/values/strings.xml
+++ b/ViewPumpSample/src/main/res/values/strings.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <string name="app_name">ViewPump</string>
-    <string name="regular_textview">This is a regular TextView</string>
+    <string name="custom_textview_prefixed_text">\n[CustomTextView] %s</string>
     <string name="regular_button">This is a regular Button</string>
+    <string name="regular_textview">This is a regular TextView</string>
 </resources>
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
index 630f7a0..bbe4e72 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-3.4.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-3.4.1-all.zip
diff --git a/viewpump/build.gradle b/viewpump/build.gradle
index ee44c81..31175e7 100644
--- a/viewpump/build.gradle
+++ b/viewpump/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.library'
 
 android {
     compileSdkVersion 25
-    buildToolsVersion "25.0.1"
+    buildToolsVersion "25.0.2"
 
     defaultConfig {
         minSdkVersion 14
@@ -18,6 +18,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'consumer-proguard-rules.pro'
         }
     }
+
+    lintOptions {
+        // we don't always want to use the latest version of the support library
+        disable 'GradleDependency'
+        textOutput 'stdout'
+        textReport System.getenv('CI') == 'true'
+    }
 }
 
 dependencies {

From 4cfab07ae6b8eb07e3574cb7ae52e92f2df31968 Mon Sep 17 00:00:00 2001
From: James Barr <barr.james.r@gmail.com>
Date: Fri, 17 Mar 2017 16:45:26 -0700
Subject: [PATCH 2/2] Bump support lib

---
 ViewPumpSample/build.gradle | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ViewPumpSample/build.gradle b/ViewPumpSample/build.gradle
index 2d9ba28..46ea21f 100644
--- a/ViewPumpSample/build.gradle
+++ b/ViewPumpSample/build.gradle
@@ -32,8 +32,8 @@ android {
 
 dependencies {
     compile project(':viewpump')
-    compile 'com.android.support:support-v4:25.2.0'
-    compile 'com.android.support:appcompat-v7:25.2.0'
+    compile 'com.android.support:support-v4:25.3.0'
+    compile 'com.android.support:appcompat-v7:25.3.0'
 
     compile 'com.jakewharton:butterknife:8.2.1'