Apply suggestions from code review

Infomaniak · Oct 18, 2023 · d9e5f2e · d9e5f2e
1 parent 068af29
commit d9e5f2e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/app/src/main/java/com/infomaniak/drive/ui/fileList/SortFilesBottomSheetDialog.kt b/app/src/main/java/com/infomaniak/drive/ui/fileList/SortFilesBottomSheetDialog.kt
@@ -29,10 +29,16 @@ class SortFilesBottomSheetDialog : SelectBottomSheetDialog() {
 
     private val navigationArgs: SortFilesBottomSheetDialogArgs by navArgs()
 
-    override fun onViewCreated(view: View, savedInstanceState: Bundle?) = with(navigationArgs) {
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) = with(binding) {
         super.onViewCreated(view, savedInstanceState)
-        binding.selectTitle.setText(R.string.sortTitle)
-        binding.selectRecyclerView.adapter = SortFilesBottomSheetAdapter(sortType, sortTypeUsage) { onSortTypeClicked(it) }
+
+        selectTitle.setText(R.string.sortTitle)
+
+        selectRecyclerView.adapter = SortFilesBottomSheetAdapter(
+            selectedType = navigationArgs.sortType,
+            usage = navigationArgs.sortTypeUsage,
+            onItemClicked = ::onSortTypeClicked,
+        )
     }
 
     private fun onSortTypeClicked(sortType: SortType) {

diff --git a/...c/main/java/com/infomaniak/drive/ui/menu/settings/SelectIntervalTypeBottomSheetAdapter.kt b/...c/main/java/com/infomaniak/drive/ui/menu/settings/SelectIntervalTypeBottomSheetAdapter.kt
@@ -29,7 +29,7 @@ import kotlinx.android.synthetic.main.item_select_bottom_sheet.view.itemSelectTe
 
 class SelectIntervalTypeBottomSheetAdapter(
     private val selectedIntervalType: SyncSettings.IntervalType,
-    private val onItemClicked: (intervalType: SyncSettings.IntervalType) -> Unit
+    private val onItemClicked: (intervalType: SyncSettings.IntervalType) -> Unit,
 ) : RecyclerView.Adapter<ViewHolder>() {
 
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder {
@@ -47,4 +47,4 @@ class SelectIntervalTypeBottomSheetAdapter(
     }
 
     override fun getItemCount() = SyncSettings.IntervalType.values().size
-}
+}
diff --git a/...rc/main/java/com/infomaniak/drive/ui/menu/settings/SelectIntervalTypeBottomSheetDialog.kt b/...rc/main/java/com/infomaniak/drive/ui/menu/settings/SelectIntervalTypeBottomSheetDialog.kt
@@ -37,5 +37,4 @@ class SelectIntervalTypeBottomSheetDialog : SelectBottomSheetDialog() {
             dismiss()
         }
     }
-
 }
diff --git a/app/src/main/java/com/infomaniak/drive/ui/menu/settings/SelectSaveDateBottomSheetDialog.kt b/app/src/main/java/com/infomaniak/drive/ui/menu/settings/SelectSaveDateBottomSheetDialog.kt
@@ -37,5 +37,4 @@ class SelectSaveDateBottomSheetDialog : SelectBottomSheetDialog() {
             dismiss()
         }
     }
-
 }