Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Since android 12, foreground service throw an exception #1030

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix: Since android 12, foreground service throw an exception #1030

merged 2 commits into from
Sep 20, 2023

Conversation

sirambd
Copy link
Member

@sirambd sirambd commented Sep 19, 2023

Fix #1029

@sirambd sirambd added the bug Something isn't working label Sep 19, 2023
@sirambd sirambd requested a review from a team as a code owner September 19, 2023 16:46
@sirambd sirambd self-assigned this Sep 19, 2023
@sentry-mobile
Copy link

sentry-mobile bot commented Sep 19, 2023

Sentry issue: KDRIVE-ANDROID-PM

@sirambd
fix: Since android 12, setForeground throw an exception
bdb4b8c 
Fixes KDRIVE-ANDROID-K1, fixes KDRIVE-ANDROID-PM, fixes KDRIVE-ANDROID-FK
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sirambd sirambd mentioned this pull request Sep 20, 2023
Merged
@JorisBodin JorisBodin merged commit 8c9704f into master Sep 20, 2023
2 of 3 checks passed
@JorisBodin JorisBodin deleted the fix-invalid-foreground branch September 20, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisBodin JorisBodin JorisBodin approved these changes

Assignees

@sirambd sirambd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@sirambd @JorisBodin