Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apiv3-4 clean code for trash #1068

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Apiv3-4 clean code for trash #1068

merged 5 commits into from
Nov 9, 2023

Conversation

sirambd
Copy link
Member

@sirambd sirambd commented Oct 20, 2023 •
edited
Loading

Depends on #1067

@sirambd sirambd added the feature A new functionality is added to the product label Oct 20, 2023
@sirambd sirambd self-assigned this Oct 20, 2023
@sirambd sirambd requested a review from a team as a code owner October 20, 2023 08:24
@sirambd sirambd mentioned this pull request Oct 20, 2023
Merged
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 4b18db5 to c5f800f Compare October 24, 2023 07:43
@sirambd sirambd force-pushed the apiv3-3-most-recent-changes branch 2 times, most recently from 397ba0d to 0be8a7f Compare October 24, 2023 09:49
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from c5f800f to 8ab1ab1 Compare October 24, 2023 09:50
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 8ab1ab1 to 92c09e4 Compare October 24, 2023 14:03
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 92c09e4 to 5994ae6 Compare October 26, 2023 08:33
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 5994ae6 to 0b1f7af Compare October 26, 2023 08:42
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 0b1f7af to 0397fad Compare October 26, 2023 13:00
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 0397fad to 807ce2b Compare October 26, 2023 16:59
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch 2 times, most recently from 227c7c1 to 13146e2 Compare October 27, 2023 11:24
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 13146e2 to b5f696e Compare October 27, 2023 11:29
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from b5f696e to 6c630db Compare October 27, 2023 11:47
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 6c630db to 0949672 Compare October 27, 2023 12:16
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 0949672 to 44e4b22 Compare October 27, 2023 14:31
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 44e4b22 to 8dc6881 Compare October 30, 2023 16:25
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from f6724a6 to 945a6c1 Compare October 31, 2023 09:28
@sirambd sirambd force-pushed the apiv3-4-clean-code-for-trash branch from 945a6c1 to 65e190e Compare October 31, 2023 09:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Base automatically changed from apiv3-3-most-recent-changes to api-v3 November 9, 2023 08:47
@tevincent tevincent merged commit b9aedb5 into api-v3 Nov 9, 2023
2 checks passed
@tevincent tevincent deleted the apiv3-4-clean-code-for-trash branch November 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianDevel FabianDevel FabianDevel approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@sirambd sirambd

Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirambd @FabianDevel @tevincent