-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong snackbar being displayed when importing files on low memory #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyDL-Infomaniak
added
bug
Something isn't working
quick
A pull request consisting of a few lines
labels
May 23, 2024
LunarX
requested changes
May 23, 2024
app/src/main/java/com/infomaniak/drive/ui/addFiles/ImportFilesDialog.kt
Outdated
Show resolved
Hide resolved
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 10:33
96a70d3
to
2b6df51
Compare
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 10:36
2b6df51
to
78aff22
Compare
LunarX
requested changes
May 23, 2024
app/src/main/java/com/infomaniak/drive/ui/addFiles/ImportFilesDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/addFiles/ImportFilesDialog.kt
Outdated
Show resolved
Hide resolved
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 11:05
78aff22
to
d798907
Compare
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 11:52
d798907
to
b64f0c9
Compare
FabianDevel
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a snackbar that appears to be useless, because we display the same snackbar in onDismiss() and initUpload()
app/src/main/java/com/infomaniak/drive/ui/addFiles/ImportFilesDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/addFiles/ImportFilesDialog.kt
Outdated
Show resolved
Hide resolved
FabianDevel
approved these changes
May 23, 2024
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 13:24
b00d0d6
to
3a63db0
Compare
TommyDL-Infomaniak
force-pushed
the
fix/snackbar-islowmemory
branch
from
May 23, 2024 13:26
71bdca8
to
3f9c57a
Compare
Quality Gate passedIssues Measures |
LunarX
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
before.mov
After:
after.mov