08 manage password protected share #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
force-pushed
the
07-publicShare-fix-multiselect
branch
from
f0e8a41
to
1a860a0
Compare
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
from
762d914
to
98c29f5
Compare
FabianDevel
force-pushed
the
07-publicShare-fix-multiselect
branch
from
1a860a0
to
40bc48f
Compare
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
from
98c29f5
to
a9ae981
Compare
FabianDevel
force-pushed
the
07-publicShare-fix-multiselect
branch
from
40bc48f
to
8b46ae1
Compare
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
from
a9ae981
to
717520d
Compare
FabianDevel
force-pushed
the
07-publicShare-fix-multiselect
branch
from
8b46ae1
to
0ae8b86
Compare
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
from
717520d
to
ced2373
Compare
tevincent
requested changes
Sep 16, 2024
app/src/main/java/com/infomaniak/drive/ui/publicShare/PublicSharePasswordFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/publicShare/PublicSharePasswordFragment.kt
Outdated
Show resolved
Hide resolved
sirambd
requested changes
Sep 17, 2024
app/src/main/java/com/infomaniak/drive/ui/publicShare/PublicShareViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/publicShare/PublicShareViewModel.kt
Outdated
Show resolved
Hide resolved
FabianDevel
force-pushed
the
07-publicShare-fix-multiselect
branch
2 times, most recently
from
591a878
to
68c65df
Compare
Base automatically changed from
07-publicShare-fix-multiselect
to
public-shares-feature
September 17, 2024 11:18
|
This PR/issue depends on:
|
Quick hack as long as the Backend doesn't support password management with bearer token
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
3 times, most recently
from
035ebdf
to
dffe4c9
Compare
FabianDevel
force-pushed
the
08-manage-password-protected-share
branch
from
dffe4c9
to
0cbf6bc
Compare
|
tevincent
approved these changes
Sep 18, 2024
sirambd
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1402
Add the management of password protected share link.
As the backend isn't ready for Bearer logic on the public share routes (it only relies on cookies), the current situation is that we redirect the user to the browser for these links