Fixes all warnings about uninitialized member variables in constructors (cppcheck) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-guyot-infomaniak
requested review from
ChristopheLarchier,
herve-er and
ClementKunz
and removed request for
a team and
herve-er
herve-er
reviewed
Sep 19, 2024
ChristopheLarchier
previously approved these changes
Sep 20, 2024
…ferencement of invalid iterator
luc-guyot-infomaniak
force-pushed
the
fix-all-uninitialized-member-warnings-detected-by-cppcheck
branch
from
973b38a
to
2e4abb8
Compare
…ected-by-cppcheck
…ected-by-cppcheck
ClementKunz
reviewed
Oct 8, 2024
Comment on lines
+24
to
+26
| _time(0), _level(ErrorLevel::Unknown), _syncDbId(0), _exitCode(ExitCode::Unknown), _exitCause(ExitCause::Unknown), | ||
| _nodeType(NodeType::Unknown), _conflictType(ConflictType::None), _inconsistencyType(InconsistencyType::None), | ||
| _cancelType(CancelType::None) {} |
There was a problem hiding this comment.
Why not giving default values to all those variables in the header file?
ClementKunz
reviewed
Oct 8, 2024
Comment on lines
+24
to
+26
| _type(NodeType::Unknown), _newPath(std::nullopt), _localNodeId(std::nullopt), _remoteNodeId(std::nullopt), | ||
| _direction(SyncDirection::Unknown), _instruction(SyncFileInstruction::None), _status(SyncFileStatus::Unknown), | ||
| _conflict(ConflictType::None), _inconsistency(InconsistencyType::None), _size(0), _dehydrated(false), _confirmed(false), | ||
| _timestamp(std::time(0)) {} | ||
| _conflict(ConflictType::None), _inconsistency(InconsistencyType::None), _size(0) {} |
There was a problem hiding this comment.
Those variables could be initialized in header file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make sure all non initialized member variables detected by
cppcheckare initialized in constructors.The following command was used: