[KDESKTOP-1129] Enables new compilation warnings with a view to sanitize code #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-guyot-infomaniak
changed the title
|
|
||
| std::vector<char> cstr(maxUtf8Bytes, '\0'); | ||
| auto result = CFStringGetCString(cfstring, cstr.data(), cstr.size(), kCFStringEncodingUTF8); | ||
| std::vector<char> cstr(static_cast<size_t>(maxUtf8Bytes), '\0'); |
There was a problem hiding this comment.
This cast is now required for the compilation to succeeds.
luc-guyot-infomaniak
force-pushed
the
enable-compilation-warnings
branch
from
15a0a69
to
f095f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step toward a zero warning policy as depicted in KDESKTOP-1129, these changes enable a series of compilation warnings that will help sanitize code and increase runtime safety.