Kdesktop 1275 sync on fat system are broken #338
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6ee1144.
…rguments to determine fsSupportsSymlinks on Windows, as this behavior is not consistent between Visual Studio 2019 and Visual Studio 2022
ClementKunz
reviewed
Oct 8, 2024
…e negative in checkIfPathExists.
…/github.com/Infomaniak/desktop-kDrive into KDESKTOP-1275-Sync-on-FAT-system-are-broken
Co-authored-by: Luc Guyot <162997198+luc-guyot-infomaniak@users.noreply.github.com>
…/github.com/Infomaniak/desktop-kDrive into KDESKTOP-1275-Sync-on-FAT-system-are-broken
luc-guyot-infomaniak
previously approved these changes
Oct 9, 2024
Co-authored-by: Luc Guyot <162997198+luc-guyot-infomaniak@users.noreply.github.com>
…ither a dir or a file
|
ChristopheLarchier
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkIfPathExistfunction has been optimized for better performance. However, there is a known issue when calling this function with a path on a FAT32 disk in Visual Studio versions before 17.3 Preview 2. In such cases, the function returns invalid arguments due to a bug in Visual Studio (msvc). More details about this bug can be found in the following link: std::filesystem::is_symlink is broken on FAT.This issue has a high impact as all sync operations on FAT32 disks are currently not working.