Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kdesktop 1275 sync on fat system are broken #338

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Kdesktop 1275 sync on fat system are broken #338

wants to merge 18 commits into from

Commits on Oct 7, 2024

  1. IoHelper::checkIfPathExists fix for FAT32/exFAT Disk.

    @herve-er
    herve-er committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e20f941 View commit details
    Browse the repository at this point in the history

  2. IoHelper::getFileStat fix for FAT32/exFAT Disk.

    @herve-er
    herve-er committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6ee1144 View commit details
    Browse the repository at this point in the history

  3. Revert "IoHelper::getFileStat fix for FAT32/exFAT Disk." 

    This reverts commit 6ee1144.
    @herve-er
    herve-er committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6917d85 View commit details
    Browse the repository at this point in the history

  4. We should not rely on std::filesystem::is_symlink returning invalid a… 

    …rguments to determine fsSupportsSymlinks on Windows, as this behavior is not consistent between Visual Studio 2019 and Visual Studio 2022
    @herve-er
    herve-er committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d2d8051 View commit details
    Browse the repository at this point in the history

  5. Consolidate IoHelper::checkIfPathExists fix for FAT32 disk.

    @herve-er
    herve-er committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bff9e61 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'develop' into KDESKTOP-1275-Sync-on-FAT-system-are-broken

    @ClementKunz
    ClementKunz authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    06cc7ab View commit details
    Browse the repository at this point in the history

  2. Ensure that we do not misinterpret an invalidArgument error as a fals… 

    …e negative in checkIfPathExists.
    @herve-er
    herve-er committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5125d61 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'KDESKTOP-1275-Sync-on-FAT-system-are-broken' of https:/… 

    …/github.com/Infomaniak/desktop-kDrive into KDESKTOP-1275-Sync-on-FAT-system-are-broken
    @herve-er
    herve-er committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    11ba739 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Luc Guyot <162997198+luc-guyot-infomaniak@users.noreply.github.com>
    @herve-er @luc-guyot-infomaniak
    herve-er and luc-guyot-infomaniak authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a45ed8e View commit details
    Browse the repository at this point in the history

  5. Uniformization of _WIN32 in #ifdef or #ifndef

    @herve-er
    herve-er committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ff0ce59 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'KDESKTOP-1275-Sync-on-FAT-system-are-broken' of https:/… 

    …/github.com/Infomaniak/desktop-kDrive into KDESKTOP-1275-Sync-on-FAT-system-are-broken
    @herve-er
    herve-er committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e845dea View commit details
    Browse the repository at this point in the history

  7. Prefer ifdef instead of ifndef.

    @herve-er
    herve-er committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d120287 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into KDESKTOP-1275-Sync-on-FAT-system-are-broken

    @herve-er
    herve-er authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    79d37fc View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into KDESKTOP-1275-Sync-on-FAT-system-are-broken

    @herve-er
    herve-er authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ef2b45f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'develop' into KDESKTOP-1275-Sync-on-FAT-system-are-broken

    @ClementKunz
    ClementKunz authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5d1438f View commit details
    Browse the repository at this point in the history

  2. Update src/libcommonserver/io/iohelper.cpp 

    Co-authored-by: Luc Guyot <162997198+luc-guyot-infomaniak@users.noreply.github.com>
    @herve-er @luc-guyot-infomaniak
    herve-er and luc-guyot-infomaniak authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3915c59 View commit details
    Browse the repository at this point in the history

  3. Replace dirPath with targetPath in utility when a method can accept e… 

    …ither a dir or a file
    @herve-er
    herve-er committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b3028ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into KDESKTOP-1275-Sync-on-FAT-system-are-broken

    @herve-er
    herve-er authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9676a24 View commit details
    Browse the repository at this point in the history