chore(person): introduce incomplete date of death

Informatievlaanderen · Aug 12, 2024 · c341730 · c341730
1 parent 24201bc
commit c341730
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/...s/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/MagdaResponsePerson.java b/...s/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/MagdaResponsePerson.java
@@ -141,12 +141,21 @@ public NodeDetailedRelatedPerson(Node node) {
         }
 
         @Override
+        @Deprecated(forRemoval = true)
         public Optional<LocalDate> deathDate() {
             return node.get("Overlijden/Datum")
                        .flatMap(Node::getValue)
                        .map(LocalDate::parse);
         }
 
+        @Override
+        public Optional<IncompleteDate> incompleteDateOfDeath() {
+            return node.get("Overlijden/Datum")
+                       .flatMap(Node::getValue)
+                       .map(IncompleteDate::fromString);
+        }
+
+
         @Override
         public Address mainResidence() {
             return node.get("Adressen/Hoofdverblijfplaats")

diff --git a/interfaces/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/Person.java b/interfaces/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/Person.java
@@ -104,6 +104,11 @@ interface DetailedRelatedPerson extends RelatedPerson {
          */
         Optional<LocalDate> deathDate();
 
+        /**
+         * The person's (potentially incomplete) date of death
+         */
+        Optional<IncompleteDate> incompleteDateOfDeath();
+
         /**
          * The address of the person's main residence.
          */

diff --git a/...laanderen/vip/mock/magda/client/domain/giveperson/MagdaResponsePersonIntegrationTest.java b/...laanderen/vip/mock/magda/client/domain/giveperson/MagdaResponsePersonIntegrationTest.java
@@ -62,6 +62,11 @@ void deathDateNull_whenMissing() {
             assertThat(self.deathDate().isEmpty(), is(true));
         }
 
+        @Test
+        void incompleteDeathDateNull_whenMissing() {
+            assertThat(self.incompleteDateOfDeath().isEmpty(), is(true));
+        }
+
         @Test
         void mapsNISCodeCountry() { assertThat(self.mainResidence().nisCodeCountry(), is(Optional.of("150"))); }
 
@@ -76,6 +81,11 @@ void mapsDeathDate() {
             MatcherAssert.assertThat(person("65712399877").self().deathDate().get(), is(equalTo(LocalDate.of(2002, 1, 1))));
         }
 
+        @Test
+        void mapsIncompleteDeathDate(){
+            MatcherAssert.assertThat(person("65712399877").self().incompleteDateOfDeath().get().toLocalDate(), is(equalTo(LocalDate.of(2002, 1, 1))));
+        }
+
         @Test
         void mapsMainResidence_caseA() {
             var address = person("78721626143").self().mainResidence();