Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InnerSource License: Added Robert Bosch GmbH as known instance #532

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

gruetter
Copy link
Contributor

No description provided.

@gruetter gruetter added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Mar 14, 2023
@gruetter gruetter self-assigned this Mar 14, 2023
@spier spier changed the title Added Robert Bosch GmbH as known instance InnerSource License: Added Robert Bosch GmbH as known instance Mar 16, 2023
spier added 2 commits March 21, 2023 08:22
First listing all orgs in the Known Instances, then listing any additional details after that.
@spier
Copy link
Member

spier commented Mar 21, 2023

@gruetter I changed the formatting of this to first list all orgs in the known instances, and then go into the case details after that.

This would also allow us to merge this as is, if you don't have time to add the case details for Bosch. Just let us know how you want to go about this.

- **DB Systel**
- **Robert Bosch GmbH**

## DB Systel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we wanted to add a new section "## Robert Bosch GmbH" here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @spier : I have written a short paragraph and am currently clearing that internally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gruetter would you prefer to wait and add this to this PR, or shall we go ahead and merge, and handle future additions in a separate PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted to merge now. Will leave this thread open.

@spier
Copy link
Member

spier commented Oct 1, 2023

@gruetter thank you again for sharing your stories from Robert Bosch with the community here.

Do you have time to work on the open comments on this PR/review?

If not then I suggest that we only mention Bosch as a Known Instance, and leave any other additions that you want to make to future PRs.

@spier
Copy link
Member

spier commented Nov 20, 2023

Contacted the author via Slack again.

patterns/2-structured/innersource-license.md Outdated Show resolved Hide resolved
- **DB Systel**
- **Robert Bosch GmbH**

## DB Systel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @spier : I have written a short paragraph and am currently clearing that internally.

@spier spier marked this pull request as ready for review November 23, 2023 08:56
@spier
Copy link
Member

spier commented Nov 24, 2023

@gruetter I am opting to merge this now, so that we don't create merge conflicts with future changes to this pattern. (we almost had one right now already, as Airbus was added to the Known Instances)

But if you get clearance to share more about how you are applying this pattern, please open a new PR.

spier and others added 2 commits November 24, 2023 21:55
…erSource to open source

Co-authored-by: Georg Grütter <gruetter@gmail.com>
@spier spier merged commit 5e711f0 into main Nov 24, 2023
11 checks passed
@spier spier deleted the gruetter-patch-1 branch November 24, 2023 20:57
rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
…SourceCommons#532)

* Added Robert Bosch GmbH as Known Instance
* Add another force related to possible relicensing when moved from InnerSource to open source
* Reformatting pattern, to include Airbus reference (pulled in via last update from main)

---------

Co-authored-by: Sebastian Spier <github@spier.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants