-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new translation language: Galician #613
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
Awesomeness in the making @psanxiao! Will get back to this shortly. |
@psanxiao thank you again for this contribution. I made various tiny fixes to the markdown formatting. Those were just house-keeping items though, that make it simpler for us to maintain these patterns. Further I found some broken links, which I fixed as well. Just for two of these links I wasn't sure. I found these links to files that don't exist:
I have fixed those links as well to point to the English version of those files instead. If you were still intending to translate those files to Galician too, you can certainly do that. However you don't have to as the translations to Japanese/Chinese etc have not done that either (i.e. they kept the English versions as well). Also at least for the mind-map it will be a bit trickier to do the translation, as we have some automation there that generates the mindmap, which we would have to fix too. |
Thank you very much @spier for reviewing and for all the fixes. About those links that you mentioned, yeah, it was my fault. I did not upload those files in the previous commits. But, taking into account what you say, maybe it has no sense to upload the translation for those files. |
Oh, well if you already have those fixes anyways, by all means, please add them to the PR @psanxiao ! |
Btw there is something that I need to clarify with the gitbook Support team before publishing the Galician version of the patterns. So it will likely take until early next week. Just to set expectations :) |
…ixed links related to them
No problem with that. Thank you very much for all your work done. |
You got it :) Actually I think I was able to resolve the issue. |
…ot exist. Fix links." This reverts commit fccd0ee.
Note to self: |
Also after this PR we get to do some continuity testing immediate, as in the meantime there is another pattern that needs translation :) (see Standard Release Process) |
I think I checked this PR sufficiently now, and am happy to get this merged tomorrow, and published in our online book. This will be so cool 🥳 One more question for you though @psanxiao: So, would you like to be the translation lead for Galician? :) |
Sure! :) |
* Added Galician translation (incl. some translated images, mindmap, and pattern template) * Added @psanxiao as translation lead for Galician --------- Co-authored-by: Sebastian Spier <github@spier.hu>
This PR adds a new entirely translation to Galician language. Includes:
This translation was made possible thank you to Xunta de Galicia, local goverment of Galicia region, as part as project to foster InnerSource practiques among the Galician companies.
People who participate in the translation work were:
We hope you find interesting this contribution and we looking forward to your feedback. Let us know any change that we should made so that this PR could be integrated.
Thank you in advance for your time.