-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammatical modifications added to the Galician translation in the texts of the corresponding .md files #680
Grammatical modifications added to the Galician translation in the texts of the corresponding .md files #680
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
These changes are now live: |
@psanxiao one question: However this also means that when opening the pattern itself, it will look like this. Is this intended and correct in Galician to start a sentence with a lower case letter? |
Good point @spier . Changes are made because of TOC, correct. In the TOC, descriptions should be in lowercase in Galician, but as you pointed out, Patlets should start in uppercase since you're right, sentences in Galician start in uppercase. I guess there is no a good solution for this with the current configuration of the repository. As lesser of two I think it would be better Patlets start in uppercase. Sorry about not realize of that. I have to make some other minor change nexts days so I could take advantage of it and make that change... Or you think it would be better remove the commit of the PR from main branch and make another one taking this into account? |
I would revert the commit(s) that lowercased the Patlets first, as that will be rather quick. And then make the other changes in another PR. But up to you. |
Grammatical modifications added to the Galician translation in the texts of the corresponding .md files.