Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files #680

Merged

Conversation

raivenra
Copy link
Contributor

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files.

Copy link

welcome bot commented Apr 10, 2024

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@raivenra raivenra requested a review from psanxiao as a code owner April 10, 2024 08:29
book/gl/toc.md Outdated Show resolved Hide resolved
@spier spier added the Type - Translation Translating patterns into other languages label Apr 10, 2024
@psanxiao psanxiao merged commit 8d3b020 into InnerSourceCommons:main Apr 11, 2024
8 checks passed
Copy link

welcome bot commented Apr 11, 2024

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@spier
Copy link
Member

spier commented Apr 12, 2024

These changes are now live:
https://patterns.innersourcecommons.org/v/gl

Great job @raivenra and @psanxiao !

@spier
Copy link
Member

spier commented Apr 12, 2024

@psanxiao one question:
I noticed that the first letter in the Patlet of the translated patterns was changed to lowercase. I assume that was done to achieve the desired formatting in toc.md?

galego-toc

However this also means that when opening the pattern itself, it will look like this. Is this intended and correct in Galician to start a sentence with a lower case letter?

galego-patlet-modifications

@psanxiao
Copy link
Collaborator

Good point @spier . Changes are made because of TOC, correct. In the TOC, descriptions should be in lowercase in Galician, but as you pointed out, Patlets should start in uppercase since you're right, sentences in Galician start in uppercase.

I guess there is no a good solution for this with the current configuration of the repository. As lesser of two I think it would be better Patlets start in uppercase. Sorry about not realize of that. I have to make some other minor change nexts days so I could take advantage of it and make that change...

Or you think it would be better remove the commit of the PR from main branch and make another one taking this into account?

@spier
Copy link
Member

spier commented Apr 12, 2024

I would revert the commit(s) that lowercased the Patlets first, as that will be rather quick.

And then make the other changes in another PR.

But up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Translation Translating patterns into other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants