Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove sub-project drama-queen #274

Merged
merged 4 commits into from
Dec 12, 2024
Merged

feat: remove sub-project drama-queen #274

merged 4 commits into from
Dec 12, 2024

Conversation

QRuhier
Copy link
Contributor

@QRuhier QRuhier commented Dec 11, 2024

No description provided.

@QRuhier QRuhier requested a review from laurentC35 December 11, 2024 17:20
@QRuhier QRuhier force-pushed the feat/remove-subproject-dramaqueen branch from 6f4ff0d to 6fc770a Compare December 12, 2024 07:41
laurentC35
laurentC35 requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@laurentC35 laurentC35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 😉

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@QRuhier QRuhier requested a review from laurentC35 December 12, 2024 09:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.7% Coverage on New Code (required ≥ 50%)
3.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@laurentC35 laurentC35 merged commit 0fd1117 into 2.3 Dec 12, 2024
9 of 10 checks passed
@laurentC35 laurentC35 deleted the feat/remove-subproject-dramaqueen branch December 12, 2024 10:30
@QRuhier QRuhier mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentC35 laurentC35 Awaiting requested review from laurentC35

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QRuhier @laurentC35